[AIRFLOW-5828] Move build logic out from hooks/build #7618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dimberman @nuclearpinguin @mik-laj @kaxil -> this is the final stage of simplifying the build scripts from breeze - now all the build logic is nicely separated out into functions and travis's hooks/build has no logic -> everything is in the scripts/ci/_utils.sh as functions. This is final stage of #6500 which I am closing now. |
5 tasks
potiuk
force-pushed
the
AIRFLOW-5828-move-build-logic-out-of-hooks-build
branch
2 times, most recently
from
eccd41f
to
4e512dd
Compare
mik-laj
reviewed
Mar 4, 2020
potiuk
force-pushed
the
AIRFLOW-5828-move-build-logic-out-of-hooks-build
branch
3 times, most recently
from
7050c48
to
4767d7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #7618 +/- ##
==========================================
- Coverage 86.83% 86.83% -0.01%
==========================================
Files 897 897
Lines 42805 42805
==========================================
- Hits 37170 37169 -1
- Misses 5635 5636 +1
Continue to review full report at Codecov.
|
|
@nuclearpinguin @mik-laj -> this one makes the build scripts much, much better. PTAL. I'd love to finally merge that one and complete all the vastly simplify of breeze scripts :) |
potiuk
force-pushed
the
AIRFLOW-5828-move-build-logic-out-of-hooks-build
branch
from
4767d7d
to
3f7662b
Compare
turbaszek
approved these changes
Mar 7, 2020
|
LGTM :) |
This is the final step of simplifying the Breeze scripts by moving all the logic out from Travis' hooks/build
potiuk
force-pushed
the
AIRFLOW-5828-move-build-logic-out-of-hooks-build
branch
from
3f7662b
to
6a6df84
Compare
potiuk
added a commit
that referenced
this pull request
Mar 7, 2020
This is the final step of simplifying the Breeze scripts by moving all the logic out from Travis' hooks/build (cherry picked from commit d18513c)
pgodek
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 12, 2020
This is the final step of simplifying the Breeze scripts by moving all the logic out from Travis' hooks/build
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
This is the final step of simplifying the Breeze scripts by moving all the logic out from Travis' hooks/build (cherry picked from commit d18513c)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
This is the final step of simplifying the Breeze scripts by moving all the logic out from Travis' hooks/build (cherry picked from commit d18513c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step of simplifying the Breeze scripts by
moving all the logic out from Travis' hooks/build
Issue link: AIRFLOW-5828
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.